[go: up one dir, main page]
Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Add Github Actions support #160

Merged
merged 12 commits into from
Sep 16, 2020
Merged

Add Github Actions support #160

merged 12 commits into from
Sep 16, 2020

Conversation

ibrahim0814
Copy link
Contributor

Purpose

Currently there's no way for the node uploader to detect Actions CI/CD pipelines. This PR adds support for it.

Note: There's currently no way to obtain a build_url or build number from the Actions environment variables. That's why they've been excluded in this PR.

@ibrahim0814
Copy link
Contributor Author

@eddiemoore Do you know why these tests are failing? I can't really tell why from the output on Travis

@kinow kinow mentioned this pull request Dec 10, 2019
Closed
eddiemoore
eddiemoore suggested changes Jan 31, 2020
View reviewed changes
test/services/github_actions.test.js Outdated Show resolved Hide resolved
test/services/github_actions.test.js Outdated Show resolved Hide resolved
@eddiemoore
Copy link
Collaborator

Sorry it's taken me so long to review this because of my current work.

@codecov
Copy link
codecov bot commented Jan 31, 2020 •
edited
Loading

Codecov Report

Merging #160 into master will increase coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   83.78%   84.25%   +0.46%     
==========================================
  Files          22       23       +1     
  Lines         370      381      +11     
  Branches       92       95       +3     
==========================================
+ Hits          310      321      +11     
  Misses         49       49              
  Partials       11       11
Impacted Files Coverage Δ
lib/detect.js 92.30% <ø> (ø)
lib/services/github_actions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2d353...3bc49d4. Read the comment docs.

@ibrahim0814
Copy link
Contributor Author

@eddiemoore No worries! Fixed the jest assertions and Travis is now passing.

eddiemoore
eddiemoore suggested changes Feb 1, 2020
View reviewed changes
lib/services/github_actions.js Outdated Show resolved Hide resolved
test/services/github_actions.test.js Outdated Show resolved Hide resolved
@ibrahim0814
Copy link
Contributor Author

Corrected the service name!

@JustinBeckwith
Copy link
Contributor

Greetings folks! This is a change that would make our lives much easier :) Anything I can do to help it get merged?

@ibrahim0814 ibrahim0814 closed this Mar 6, 2020
@ibrahim0814 ibrahim0814 reopened this Mar 6, 2020
@ibrahim0814
Copy link
Contributor Author

Accidentally closed this PR, sorry about that. @eddiemoore, is this ready to merge?

kincaidoneil added a commit to interledgerjs/interledgerjs that referenced this pull request May 19, 2020
@kincaidoneil
chore: fix codecov branch reporting
6a980d6 
- codecov npm module doesn't support GitHub Actions/correctly report branches: codecov/codecov-node#160
- switch to codecov bash uploader
@jobara jobara mentioned this pull request Jul 29, 2020
Merged
@thomasrockhu thomasrockhu self-requested a review August 24, 2020 23:28
@thomasrockhu thomasrockhu reopened this Sep 8, 2020
@thomasrockhu thomasrockhu merged commit 33300b5 into codecov:master Sep 16, 2020
@thomasrockhu
Copy link
Contributor

As always, thanks @ibrahim0814

This was referenced Sep 6, 2024
Open
Open
This was referenced Sep 13, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 21, 2024
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thomasrockhu thomasrockhu thomasrockhu approved these changes

@eddiemoore eddiemoore Awaiting requested review from eddiemoore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibrahim0814 @eddiemoore @JustinBeckwith @thomasrockhu