[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JME, Nano] Add eta and phi of muon-subtracted raw jet for MET type-1 correction consistency #46676

Merged
merged 3 commits into from
Nov 13, 2024
Merged

[JME, Nano] Add eta and phi of muon-subtracted raw jet for MET type-1 correction consistency #46676

merged 3 commits into from
Nov 13, 2024

Conversation

nurfikri89
Copy link
Contributor

PR description:

This PR adds the eta and phi of the muon-subtracted raw jets. These are needed so that the MET type-1 (re-)calculation with NanoAOD will be more consistent with the type-1 calculation done at the PAT step.

PR validation:

  • passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos with the exception of a few workflows which failed because of missing relval input files.
  • passes MiniAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Nov 12, 2024
@cmsbuild
Copy link
Contributor
cmsbuild commented Nov 12, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46676/42599

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46676/42602

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • JetMETCorrections/Type1MET (reconstruction)
  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AnnikaStein, @ahinzmann, @clelange, @gkasieczka, @gouskos, @gpetruc, @jdamgov, @jdolen, @mariadalfonso, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@hqucms
Copy link
Contributor
hqucms commented Nov 12, 2024

please abort

@hqucms
Copy link
Contributor
hqucms commented Nov 12, 2024

enable nano

@hqucms
Copy link
Contributor
hqucms commented Nov 12, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a648e/42764/summary.html
COMMIT: 9c1fbf4
CMSSW: CMSSW_14_2_X_2024-11-12-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46676/42764/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
2024.101001 step 1
2024.202001 step 1
2024.303001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 61 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3070351
  • DQMHistoTests: Total failures: 412
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3069919
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 32.071 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 2.531 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 1.689 KiB Physics/NanoAODDQM
  • Checked 190 log files, 160 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 536 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 55722
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 55722
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 24.478 KiB( 20 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 2.531 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 1.689 KiB Physics/NanoAODDQM
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.073 3.052 0.021 ( +0.7% ) 2.77 2.71 +2.2% 2.506 2.523
2500.002 3.189 3.164 0.025 ( +0.8% ) 2.49 2.45 +1.9% 2.952 2.953
2500.003 3.130 3.105 0.025 ( +0.8% ) 2.60 2.56 +1.5% 2.923 2.933
2500.011 1.643 1.621 0.023 ( +1.4% ) 4.29 4.22 +1.7% 2.622 2.611
2500.012 2.183 2.153 0.030 ( +1.4% ) 2.56 2.55 +0.6% 2.776 2.800
2500.013 1.998 1.975 0.023 ( +1.2% ) 3.59 3.55 +1.0% 2.712 2.718
2500.021 0.022 0.022 0.000 ( +0.0% ) 0.90 0.86 +4.5% 2.562 2.555
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.87 0.83 +5.1% 2.556 2.564
2500.023 0.022 0.022 0.000 ( +0.0% ) 0.87 0.83 +5.7% 2.421 2.421
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.67 0.63 +5.7% 2.637 2.637
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.78 0.75 +4.7% 2.629 2.633
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.79 0.76 +4.1% 2.581 2.583
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.73 0.71 +2.2% 2.667 2.673
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.74 0.70 +5.3% 2.641 2.651
2500.101 2.806 2.788 0.019 ( +0.7% ) 6.90 6.71 +2.8% 2.625 2.616
2500.111 1.461 1.447 0.014 ( +1.0% ) 13.55 13.27 +2.1% 2.328 2.320
2500.112 1.881 1.867 0.014 ( +0.7% ) 11.39 11.08 +2.8% 2.398 2.395
2500.131 0.747 0.747 0.000 ( +0.0% ) 17.95 17.44 +2.9% 1.410 1.520
2500.201 2.634 2.617 0.018 ( +0.7% ) 5.89 5.57 +5.9% 2.131 2.171
2500.211 1.804 1.786 0.018 ( +1.0% ) 11.71 11.43 +2.5% 2.105 2.389
2500.212 2.200 2.182 0.018 ( +0.8% ) 10.05 9.97 +0.8% 2.207 2.473
2500.221 2.034 2.028 0.005 ( +0.3% ) 6.19 5.93 +4.4% 2.044 2.095
2500.222 3.435 3.415 0.019 ( +0.6% ) 5.71 5.53 +3.3% 2.138 2.188
2500.223 9.400 9.380 0.020 ( +0.2% ) 1.76 1.70 +3.4% 2.201 2.263
2500.224 6.257 6.063 0.193 ( +3.2% ) 0.58 0.57 +2.3% 2.252 2.206
2500.225 6.303 6.111 0.193 ( +3.2% ) 0.55 0.54 +2.7% 2.466 2.424
2500.226 3.129 3.109 0.019 ( +0.6% ) 5.94 5.75 +3.3% 2.190 2.183
2500.227 1.437 1.437 0.000 ( +0.0% ) 11.55 11.22 +3.0% 1.430 1.433
2500.231 1.454 1.449 0.005 ( +0.4% ) 9.99 9.58 +4.2% 2.281 2.285
2500.232 2.459 2.441 0.018 ( +0.7% ) 9.50 9.17 +3.6% 2.386 2.384
2500.233 4.951 4.933 0.018 ( +0.4% ) 2.60 2.52 +3.2% 2.445 2.445
2500.234 3.838 3.700 0.138 ( +3.7% ) 0.74 0.73 +2.2% 2.414 2.174
2500.235 3.869 3.730 0.139 ( +3.7% ) 0.71 0.70 +0.8% 2.612 2.368
2500.236 2.249 2.232 0.018 ( +0.8% ) 10.00 9.51 +5.2% 2.388 2.381
2500.237 1.016 1.016 0.000 ( +0.0% ) 16.94 16.31 +3.9% 1.459 1.440
2500.241 9.404 9.404 0.000 ( +0.0% ) 3.58 3.42 +4.7% 1.922 1.914
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.87 0.82 +5.7% 1.709 1.274
2500.243 2.712 2.712 0.000 ( +0.0% ) 8.18 7.19 +13.7% 1.077 1.077
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.56 0.53 +4.8% 1.680 1.677
2500.245 823.202 823.202 0.000 ( +0.0% ) 0.74 0.71 +5.2% 1.669 1.686
2500.901 1.777 1.777 0.000 ( +0.0% ) 20.74 19.57 +6.0% 1.414 1.418
2500.902 1.626 1.626 0.000 ( +0.0% ) 20.39 20.41 -0.1% 1.324 1.323
2500.911 13.995 13.995 0.000 ( +0.0% ) 3.95 3.30 +19.6% 1.095 1.083
2500.912 0.132 0.199 -0.068 ( -33.9% ) 1.13 1.31 -13.5% 0.981 0.978
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.10 1.10 +0.5% 0.983 0.977

@jfernan2
Copy link
Contributor

+1

@hqucms
Copy link
Contributor
hqucms commented Nov 12, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 52667d3 into cms-sw:master Nov 13, 2024
13 checks passed
@cmsbuild cmsbuild mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved reconstruction-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
5 participants
@nurfikri89 @cmsbuild @jfernan2 @hqucms @mandrenguyen