[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport of #13819: Speed seeding for HLT #15280

Merged
merged 11 commits into from
Aug 26, 2016
Merged

backport of #13819: Speed seeding for HLT #15280

merged 11 commits into from
Aug 26, 2016

Conversation

fwyzard
Copy link
Contributor
@fwyzard fwyzard commented Jul 26, 2016

No description provided.

@fwyzard
Copy link
Contributor Author
fwyzard commented Jul 26, 2016

tracked at #15151

@fwyzard
Copy link
Contributor Author
fwyzard commented Jul 26, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Jul 26, 2016
@cmsbuild
Copy link
Contributor
cmsbuild commented Jul 26, 2016 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14225/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/GeometrySurface
DataFormats/GeometryVector
Geometry/CommonDetUnit
Geometry/TrackerGeometryBuilder
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaPhotonAlgos
RecoTracker/TkTrackingRegions
TrackingTools/KalmanUpdators

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Sam-Harper, @battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @rafaellopesdesa, @jhgoh, @lgray, @bellan, @HuguesBrun, @mschrode, @rovere, @gpetruc, @VinInn, @trocino, @dgulhan, @venturia this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@fwyzard fwyzard mentioned this pull request Jul 26, 2016
Closed
9 tasks
@fwyzard
Copy link
Contributor Author
fwyzard commented Jul 26, 2016

Gives 1.2%-1.3% improvement to cpu timing and throughput:

Performance for reference
average from 42 tests:
        throughput:   60.9 +/-  0.3 ev/s
        event time:  348.2 +/-  0.9 ms

Performance for backport_13819
average from 42 tests:
        throughput:   61.7 +/-  0.2 ev/s
        event time:  343.9 +/-  0.8 ms

@fwyzard
Copy link
Contributor Author
fwyzard commented Jul 26, 2016

Does not introduce any changes to HLT results over 1000 events:

Found 1000 matching events, out of which 0 have different HLT results

ianna
ianna reviewed Jul 26, 2016
View reviewed changes
Geometry/CommonDetUnit/interface/GeomDet.h
protected:
AlignmentPositionError* theAlignmentPositionError;
AlignmentPositionError* theAlignmentPositionError=nullptr;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fwyzard - would using std::unique_ptr work here?

@cmsbuild
Copy link
Contributor

-1

Tested at: 6ee70e4

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15280/14225/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestRecoEgammaElectronIdentification had ERRORS

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15280/14225/summary.html

@fwyzard
Copy link
Contributor Author
fwyzard commented Jul 27, 2016

the failure seems to be due to a missing input sample:

----- Begin Fatal Exception 26-Jul-2016 15:04:35 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootFileSequenceBase::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_7_6_0_pre4/RelValZEE_13/MINIAODSIM/PU25ns_76X_mcRun2_asymptotic_v1-v1/00000/BE21962F-DD4F-E511-B681-002354EF3BDF.root'
   Additional Info:
      [a] XrdCl::File::Open(name='root://eoscms.cern.ch//eos/cms/store/relval/CMSSW_7_6_0_pre4/RelValZEE_13/MINIAODSIM/PU25ns_76X_mcRun2_asymptotic_v1-v1/00000/BE21962F-DD4F-E511-B681-00235
' (errno=3011, code=400). No additional data servers were found.
      [b] Last URL tried: root://eoscms.cern.ch:1094//eos/cms/store/relval/CMSSW_7_6_0_pre4/RelValZEE_13/MINIAODSIM/PU25ns_76X_mcRun2_asymptotic_v1-v1/00000/BE21962F-DD4F-E511-B681-002354EF
      [c] Problematic data server: eoscms.cern.ch:1094
      [d] Disabled source: eoscms.cern.ch:1094
      [e] Input file root://eoscms.cern.ch//eos/cms/store/relval/CMSSW_7_6_0_pre4/RelValZEE_13/MINIAODSIM/PU25ns_76X_mcRun2_asymptotic_v1-v1/00000/BE21962F-DD4F-E511-B681-002354EF3BDF.root
Fallback Input file root://xrootd-cms.infn.it//store/relval/CMSSW_7_6_0_pre4/RelValZEE_13/MINIAODSIM/PU25ns_76X_mcRun2_asymptotic_v1-v1/00000/BE21962F-DD4F-E511-B681-002354EF3BDF.root also
Original exception info is above; fallback exception info is below.
      [f] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_7_6_0_pre4/RelValZEE_13/MINIAODSIM/PU25ns_76X_mcRun2_asymptotic_v1-v1/00000/BE21962F-DD4F-E511-B681-002354EF3
' (errno=3011, code=400). No additional data servers were found.
      [g] Last URL tried: root://cms-xrd-transit.cern.ch:1094//store/relval/CMSSW_7_6_0_pre4/RelValZEE_13/MINIAODSIM/PU25ns_76X_mcRun2_asymptotic_v1-v1/00000/BE21962F-DD4F-E511-B681-002354E
      [h] Problematic data server: cms-xrd-transit.cern.ch:1094
      [i] Disabled source: cms-xrd-transit.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

@fwyzard
Copy link
Contributor Author
fwyzard commented Jul 28, 2016

please test

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor
cmsbuild commented Aug 8, 2016 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14425/console

@cmsbuild
Copy link
Contributor
cmsbuild commented Aug 9, 2016

-1

Tested at: bb3c568

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15280/14425/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestSimCalorimetryHGCalSimProducers had ERRORS
---> test testRecoMETMETProducers had ERRORS
---> test runtestRecoEgammaElectronIdentification had ERRORS

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

@cvuosalo
Copy link
Contributor
cvuosalo commented Aug 9, 2016

@cmsbuild please test
@smuzaffar says 80X Jenkins tests should complete now

@cmsbuild
Copy link
Contributor
cmsbuild commented Aug 9, 2016 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14446/console

@cmsbuild
Copy link
Contributor
cmsbuild commented Aug 9, 2016

-1

Tested at: bb3c568

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15280/14446/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testJetMETCorrectionsType1MET had ERRORS
---> test runtestRecoEgammaElectronIdentification had ERRORS
---> test runtestSimCalorimetryHGCalSimProducers had ERRORS

@cmsbuild
Copy link
Contributor
cmsbuild commented Aug 9, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15280/14446/summary.html

@cvuosalo
Copy link
Contributor
cvuosalo commented Aug 9, 2016

+1

For #15280 bb3c568

Speeding up seeding for HLT.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-08-08-2300 show a few, tiny, insignificant differences. Extended tests discussed above (#15280 (comment)) show numerous, tiny differences, but they are not significant nor more than jitter and minor fluctuations. Timing tests (#15280 (comment)) show this PR provides about a 1.2% improvement.

@cvuosalo cvuosalo mentioned this pull request Aug 10, 2016
Merged
@cvuosalo cvuosalo mentioned this pull request Aug 24, 2016
Closed
@davidlange6 davidlange6 merged commit 86b00f3 into cms-sw:CMSSW_8_0_X Aug 26, 2016
@fwyzard fwyzard deleted the backport_13819_80x branch September 1, 2016 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available geometry-pending orp-pending pending-signatures reconstruction-approved simulation-pending tests-rejected
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.
7 participants
@fwyzard @cmsbuild @cvuosalo @smuzaffar @ianna @davidlange6 @VinInn