Relval matrix updates #14839

fabozzi · 2016-06-09T23:18:01Z

added 2016 relvals
same steps for all 2015 relvals
updated gensim recycling for 2017 relvals

cmsbuild · 2016-06-09T23:18:24Z

A new Pull Request was created by @fabozzi for CMSSW_8_1_X.

It involves the following packages:

Configuration/PyReleaseValidation
DPGAnalysis/Skims

@cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

fabozzi · 2016-06-09T23:18:29Z

please test

cmsbuild · 2016-06-09T23:18:41Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13452/console

cmsbuild · 2016-06-10T00:35:44Z

+1
Tested at: 0795f69
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14839/13452/summary.html

cmsbuild · 2016-06-10T01:41:12Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14839/13452/summary.html

The workflows 134.911 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

fabozzi · 2016-06-10T06:58:17Z

+1

cmsbuild · 2016-06-10T06:58:39Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 · 2016-06-10T07:56:01Z

+1

mmusich · 2016-06-10T07:56:40Z

@fabozzi, the discussion with @Martin-Grunewald at #13819 made me realise that due to the snapshot features the 2016 data relvals will consume wrong conditions.

mmusich · 2016-06-10T08:00:15Z

@fabozzi @hengne @davidlange6 would it be possible to wait for a refresh of the GT snasphots before sending the RelVals production for this cycle? @franzoni

fabozzi · 2016-06-10T09:08:03Z

@mmusich @franzoni I think it is good to have a working 2016 relval infrastructure merged in the release. We will handshake with Alca before submitting relvals to be provided to validators

davidlange6 · 2016-06-10T09:32:45Z

hopefully working includes also the GT:)

On Jun 10, 2016, at 11:08 AM, fabozzi notifications@github.com wrote:

@mmusich @franzoni I think it is good to have a working 2016 relval infrastructure merged in the release. We will handshake with Alca before submitting relvals to be provided to validators

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

mmusich · 2016-06-10T09:36:15Z

@davidlange6 technically speaking already works, but yields wrong results.
Incidentally when #14820 will be merge the problem is going to be mitigated, but I would definitely wait for the DPGs to udpate the 2016 IOVs (due in any case for the data re-reco) before releasing for validation.

davidlange6 · 2016-06-10T09:41:02Z

we have a different meaning of “works” then… but good if at least the prompt conditions are already about read to merge

On Jun 10, 2016, at 11:36 AM, Marco Musich notifications@github.com wrote:

@davidlange6 technically speaking already works, but yields wrong results.
Incidentally when #14820 will be merge the problem is going to be mitigated, but I would definitely wait for the DPGs to udpate the 2016 IOVs (due in any case for the data re-reco) before releasing for validation.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

slava77 · 2016-06-10T12:11:50Z

Configuration/PyReleaseValidation/python/relval_steps.py

@@ -183,6 +183,22 @@
 steps['RunSinglePh2015D']={'INPUT':InputInfo(dataSet='/SinglePhoton/Run2015D-v1/RAW',label='sigPh2015D',events=100000,location='STD', ls=Run2015D)}
 steps['RunZeroBias2015D']={'INPUT':InputInfo(dataSet='/ZeroBias/Run2015D-v1/RAW',label='zb2015D',events=100000,location='STD',ib_block='38d4cab6-5d5f-11e5-824b-001e67ac06a0',ls=Run2015D)}

+#### run2 2016B ####
+# Run2016B, 25ns: 274160
+Run2016B=selectedLS([274160],l_json=data_json2016)


is it possible to pick a run with CTPPS included?
274094 LS>151 or 274199 full

mmusich · 2016-06-10T15:03:13Z

@davidlange6 #14842 is a temporary solution to avoid crazy output in relvals, @franzoni and I will take care of removing the keys once the standard re-reco GT is fully up-to-date. Is this a reasonable solution?

fabozzi · 2016-06-10T15:33:18Z

@slava77 run 274199 contains more than double statistics w.r.t. what we usually run with data relvals. What about to run only on a subset of it? For instance, the first 250 lumisections?

slava77 · 2016-06-10T15:50:31Z

On 6/10/16 8:33 AM, fabozzi wrote:

@slava77 https://github.com/slava77 run 274199 contains more than
double statistics w.r.t. what we usually run with data relvals. What
about to run only on a subset of it? For instance, the first 250
lumisections?

A fraction of it is fine.
I just wanted to make sure that we exercise the CTPPS software with
realistic inputs in the matrix.

Once this settles, can you please add one 2016 workflow to the short matrix?

Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14839 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/AEdcblHf9WcYhoeX3BpzDKKrf9ucoE9Pks5qKYO_gaJpZM4IyfwO.

fabozzi · 2016-06-10T16:10:29Z

Il 10/06/16 17:50, Slava Krutelyov ha scritto:

On 6/10/16 8:33 AM, fabozzi wrote:

@slava77 https://github.com/slava77 run 274199 contains more than
double statistics w.r.t. what we usually run with data relvals. What
about to run only on a subset of it? For instance, the first 250
lumisections?

A fraction of it is fine.
I just wanted to make sure that we exercise the CTPPS software with
realistic inputs in the matrix.

Once this settles, can you please add one 2016 workflow to the short matrix?

Yes, sure

Francesco

Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14839 (comment), or
mute the thread

https://github.com/notifications/unsubscribe/AEdcblHf9WcYhoeX3BpzDKKrf9ucoE9Pks5qKYO_gaJpZM4IyfwO.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14839 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/AEo3uyIoxdpGilBlOCHtIUxsB3L5xzmTks5qKYfMgaJpZM4IyfwO.

fabozzi added 5 commits June 10, 2016 00:39

added 2016 json

b77a938

loading json file for 2016 relvals

fbe2199

adding 2016 relvals

3501d20

2015D relvals having same steps as 2015C relvals

2f06e59

updated recycling of gensim for 2017 relvals

0795f69

cmsbuild added this to the Next CMSSW_8_1_X milestone Jun 9, 2016

cmsbuild added pending-signatures tests-pending orp-pending comparison-pending pdmv-pending labels Jun 9, 2016

cmsbuild added tests-started and removed tests-pending labels Jun 9, 2016

cmsbuild added tests-approved and removed tests-started labels Jun 10, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jun 10, 2016

cmsbuild added fully-signed pdmv-approved and removed pdmv-pending pending-signatures labels Jun 10, 2016

Martin-Grunewald mentioned this pull request Jun 10, 2016

Speed seeding for HLT #13819

Merged

cmsbuild added orp-approved and removed orp-pending labels Jun 10, 2016

cmsbuild merged commit 949434f into cms-sw:CMSSW_8_1_X Jun 10, 2016

slava77 reviewed Jun 10, 2016
View reviewed changes

fabozzi mentioned this pull request Jun 14, 2016

relval matrix update #14869

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relval matrix updates #14839

Relval matrix updates #14839

Relval matrix updates #14839

Relval matrix updates #14839

Conversation

Choose a reason for hiding this comment