storage: consume args for empty types in all cases

chugiau · Mar 13, 2020 · 97e0d63 · 97e0d63
1 parent 5e04f0a
commit 97e0d63
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/TODO b/TODO
@@ -15,6 +15,7 @@
 * document undocumented parts (entt::overload and a few others)
 * any-of rule for views/groups (eg entity has A and any of B/C/D)
   - get -> all, exclude -> none
+* review multi component views to reduce instantiations once empty types are gone...
 
 Next:
 * replace observer class with observer functions

diff --git a/src/entt/entity/storage.hpp b/src/entt/entity/storage.hpp
@@ -694,16 +694,15 @@ class storage<Entity, Type, std::enable_if_t<ENTT_ENABLE_ETO(Type)>>: public spa
      *
      * @tparam Args Types of arguments to use to construct the object.
      * @param entt A valid entity identifier.
+     * @param args Parameters to use to construct an object for the entity.
      */
     template<typename... Args>
-    void emplace(const entity_type entt, Args &&...) {
+    void emplace(const entity_type entt, Args &&... args) {
+        [[maybe_unused]] object_type instance{std::forward<Args>(args)...};
         underlying_type::construct(entt);
     }
 
-    /**
-     * @copydoc emplace
-     * @param args Parameters to use to construct an object for the entity.
-     */
+    /*! @copydoc emplace */
     template<typename... Args>
     [[deprecated("use ::emplace instead")]]
     void construct(const entity_type entt, Args &&... args) {