[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof LUNAR_AND_SOLAR_EPHEMERIDES_SUBROUTINES (#224) #316

Merged
merged 2 commits into from
Mar 23, 2018
Merged

Proof LUNAR_AND_SOLAR_EPHEMERIDES_SUBROUTINES (#224) #316

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69fb7e9
Proof LUNAR_AND_SOLAR_EPHEMERIDES_SUBROUTINES (#224)
dwiyatci Mar 11, 2018
b292f92
👌 Follow "triple space" rule for indentation
dwiyatci Mar 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
👌 Follow "triple space" rule for indentation
  • Loading branch information
@dwiyatci
dwiyatci committed Mar 14, 2018
commit b292f92fd2e28550d83f8b32f885e0e58257e6e1
14 changes: 7 additions & 7 deletions Comanche055/LUNAR_AND_SOLAR_EPHEMERIDES_SUBROUTINES.agc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,30 +63,30 @@
# 1) SPECIFIED GROUND ELAPSED TIME IN CS x B-28 LOADED IN MPAC.
#
# 2) TIMEMO - TIME AT THE CENTER OF THE RANGE OVER WHICH THE LUNAR
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we handle sentence/paragraph continuation? Should we leave it be like this or should we put a tab after the number, e.g. 1)⇥ like in https://github.com/chrislgarry/Apollo-11/blob/master/Comanche055/P76.agc? 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I would probably use the format in that file since it is closer to how it looked in the printouts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change those '--' in Proof P76 (#239)

Copy link
Contributor Author
@dwiyatci dwiyatci Mar 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oldmud0 Hmm. If that's the argument, would it be even closer if we just put 3 spaces in the continuation? ⬇️

screen shot 2018-03-12 at 11 33 17 pm

@keller0 🙋‍♂️ I'm actually also kind of undecided about that. Should we use hyphen (-) or double hyphen a.k.a. en dash (--)? Furthermore, in P76, I notice that every full stop (.) is always followed by double spaces -- is it a general rule that we have to follow here?

cc: @chrislgarry @wopian

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwiyatci

  • Single space for new words
  • Double space for new sentences
  • Triple space for indentations

Moving forward, lets change double hyphens to single hyphens to be consistent with the prints. @keller0 its no problem. For new PRs lets do single hyphens unless the printout says otherwise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrislgarry Roger that. 🙇

# POSITION POLYNOMIAL IS VALID IN CS x B-42.
# POSITION POLYNOMIAL IS VALID IN CS x B-42.
#
# 3) VECOEM - VECTOR COEFFICIENTS OF THE LUNAR POSITION POLYNOMIAL
# LOADED IN DESCENDING SEQUENCE IN METERS/CS**N x B-2
# LOADED IN DESCENDING SEQUENCE IN METERS/CS**N x B-2
#
# 4) RESO - POSITION VECTOR OF THE SUN RELATIVE TO THE EARTH AT
# TIMEMO IN METERS x B-38.
# TIMEMO IN METERS x B-38.
#
# 5) VESO - VELOCITY VECTOR OF THE SUN RELATIVE TO THE EARTH AT
# TIMEMO IN METERS/CS x B-9.
# TIMEMO IN METERS/CS x B-9.
#
# 6) OMEGAES - ANGULAR VELOCITY OF THE VECTOR RESO AT TIMEMO IN
# REV/CS x B+26.
# REV/CS x B+26.
#
# ALL EXCEPT THE FIRST INPUT ARE INCLUDED IN THE PRE-LAUNCH
# ERASABLE DATA LOAD.
#
# OUTPUT - LSPOS
# Page 786
# 1) 2D OF VAC AREA CONTAINS THE POSITION VECTOR OF THE SUN RELATIVE
# TO THE EARTH AT TIME INPUT BY THE USER IN METERS x B-38.
# TO THE EARTH AT TIME INPUT BY THE USER IN METERS x B-38.
#
# 2) MPAC CONTAINS THE POSITION VECTOR OF THE MOON RELATIVE TO THE
# EARTH AT TIME INPUT BY THE USER IN METERS x B-29.
# EARTH AT TIME INPUT BY THE USER IN METERS x B-29.
#
# OUTPUT - LUNPOS
#
Expand Down