fix(awscli-v2): new cli versions are not released #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b44c79
to
82e3fce
Compare
82e3fce
to
1783f92
Compare
iliapolo
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and simplifies the failing workflow to upgrade awscli v2 and changes it from
choretofixso it gets released regularly. Changes the cadence to weekly which makes more sense for a this package.Also removes the upgrade script from this branch where it is not used. The workflow checks out the v2 branch and will run the script from there. Unfortunately the workflow must exist on the default branch (currently
awscli-v1/main) to be running on a schedule.Tested here: https://github.com/cdklabs/awscdk-asset-awscli/actions/runs/10990591519
Resulting in this PR: #962