[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example6.yaml #5611

Closed
wants to merge 2 commits into from
Closed

Update example6.yaml #5611

wants to merge 2 commits into from

Conversation

rajannpatel
Copy link

both apps and infra must be explicitly specified when enabling ESM

Proposed Commit Message

<type>(optional scope): <summary>  # no more than 72 characters

A description of what the change being made is and why it is being
made if the summary line is insufficient.  This should be wrapped at
72 characters.

If you need to write multiple paragraphs, feel free.

Fixes GH-NNNNN (GitHub Issue number. Remove line if irrelevant)
LP: #NNNNNN (Launchpad bug number. Remove line if irrelevant)

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@rajannpatel
Update example6.yaml
fbcc5a3 
both apps and infra must be explicitly specified when enabling ESM
@github-actions github-actions bot added the documentation This Pull Request changes documentation label Aug 13, 2024
blackboxsw
blackboxsw requested changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator
@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajannpatel while I think as a Canonical employee you are automatically included in the CLA clause, please also sign the contributor agreement for good measure and add your github rajannpatel alphabetically to tools/.github-cla-signers so our CI passes the licence check.

Additionally, we should update to example explanation in doc/module-docs/cc_ubuntu_pro/data.yaml for example 6 to better represent what we are doing w/ the example user-data

--- a/doc/module-docs/cc_ubuntu_pro/data.yaml
+++ b/doc/module-docs/cc_ubuntu_pro/data.yaml
@@ -42,8 +42,8 @@ cc_ubuntu_pro:
       services.
     file: cc_ubuntu_pro/example5.yaml
   - comment: >
-      Example 6: Enable ESM and beta Real-time Ubuntu services in Ubuntu Pro
-      instances.
+      Example 6: Enable ESM Infra, ESM Apps and beta Real-time Ubuntu services
+      in Ubuntu Pro instances.
     file: cc_ubuntu_pro/example6.yaml
   - comment: >
       Example 7: Disable auto-attach in Ubuntu Pro instances.

@blackboxsw blackboxsw self-assigned this Aug 13, 2024
@rajannpatel
Copy link
Author

happy to check the documentation for this example, and check it for accuracy

@blackboxsw blackboxsw added the CLA signed The submitter of the PR has signed the CLA label Aug 20, 2024
@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 4, 2024

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Sep 4, 2024
@github-actions github-actions bot closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackboxsw blackboxsw blackboxsw requested changes

Assignees

@blackboxsw blackboxsw

Labels
CLA signed The submitter of the PR has signed the CLA documentation This Pull Request changes documentation stale-pr Pull request is stale; will be auto-closed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajannpatel @blackboxsw