-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revm/evm: Return ExecutionResult
, which includes gas_refunded
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
approved these changes
Aug 11, 2022
crates/revm/src/models.rs
Outdated
@@ -388,3 +388,24 @@ pub(crate) mod serde_hex_bytes_opt { | |||
Ok(value.0.map(|b| b.0)) | |||
} | |||
} | |||
|
|||
#[derive(Debug)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
#[derive(Debug)] | |
#[derive(Debug, Clone)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
ngotchac
force-pushed
the
ngotchac/gas-refunded
branch
from
August 11, 2022 23:09
1a2a188
to
9c253d7
Compare
Closed
This was referenced Feb 8, 2024
Merged
This was referenced Feb 16, 2024
Closed
Merged
This was referenced Feb 24, 2024
Merged
This was referenced Mar 8, 2024
Merged
Closed
This was referenced Mar 25, 2024
Closed
Closed
Merged
This was referenced Apr 2, 2024
Merged
This was referenced Apr 16, 2024
This was referenced May 2, 2024
Closed
This was referenced May 13, 2024
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #167 ; now the revm/evm
transact
/inspect
methods are returning anExecutionResult
struct, which includes thegas_refunded
value.