-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(orm): txOrm miss debug log #4756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/beego/beego/blob/develop/client/orm/orm.go#L536 |
how about update this? _txOrm := &txOrm{
ormBase: ormBase{
alias: o.alias,
db: newDbQueryLog(o.alias, tx),
},
} |
_txOrm := &txOrm{ |
we can't do this, 9b14501#diff-c3b3b1de3f657359cafc028e17ae972b7e2e1a5965fe23e02d89d2cac8e021c7R2916 |
nice, please resolve the conflicts and rebase your PR to one commit id |
9b14501
to
562c6ca
Compare
317bbca
to
0e9b2c2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4756 +/- ##
===========================================
+ Coverage 54.49% 54.66% +0.16%
===========================================
Files 243 243
Lines 21723 21734 +11
===========================================
+ Hits 11839 11881 +42
+ Misses 8935 8903 -32
- Partials 949 950 +1
Continue to review full report at Codecov.
|
Please fix the golint issues(you can find them in Most of them were introduced by original developer, but I think you can help to fix them |
I will fix it later |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
|
It looks good. Thank you very much. |
Close #4674