[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sonar problem #4660

Merged
merged 1 commit into from
Jun 9, 2021
Merged

fix sonar problem #4660

merged 1 commit into from
Jun 9, 2021
+5 −34

Conversation

t29kida
Copy link
Contributor
@t29kida t29kida commented Jun 8, 2021 •
edited
Loading

Description

This PR fixes a few sonar problems.
resolve #4434 (not all)

Summary of changes

  • Delete FIXME comment, because string == "" is beter than len(string) for checking string existence(by sonar)
  • Remove duplicated code
  • Fill empty block of code

@flycash
Copy link
Collaborator
flycash commented Jun 8, 2021

please add this PR to CHANGELOG.md

@t29kida
fix sonar problem
4eb19f9 
* Delete FIXME comment, because `string == ""` is beter than `len(string)` for checking string existence(by sonar)
* Remove duplicated code
* Fill empty block of code
@sonarcloud
Copy link
sonarcloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #4660 (4eb19f9) into develop (18de06b) will increase coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4660      +/-   ##
===========================================
+ Coverage    54.83%   54.87%   +0.03%     
===========================================
  Files          242      242              
  Lines        17767    17746      -21     
===========================================
- Hits          9743     9738       -5     
+ Misses        7071     7056      -15     
+ Partials       953      952       -1
Impacted Files Coverage Δ
core/config/json/json.go 55.11% <ø> (ø)
core/logs/log.go 54.92% <33.33%> (+2.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18de06b...4eb19f9. Read the comment docs.

@flycash flycash merged commit 91392b9 into beego:develop Jun 9, 2021
@t29kida
Copy link
Contributor Author
t29kida commented Jun 9, 2021

@flycash Thank you😊

@t29kida t29kida deleted the fix-sonar-problem branch June 9, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flycash flycash flycash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help to fix Sonar problem
3 participants
@t29kida @flycash @codecov-commenter