forked from bitpay/wallet
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fb takyoon message onchain #149
Open
takYoon
wants to merge
23
commits into
master
Choose a base branch
from
fb-takyoon-message-onchain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: fix some feedback hot fix product # Conflicts: # src/app/pages/home/home.ts
* fb-takyoon-tmp-onchain: apply logic encrypt and decrypt message
* master: improve performance home card refactor code handle some feedback fix asset to build android handle some case show get started page not correct polish ui scan eToken fix bug scan eToken some case add command to build android handle some case scan eToken change model for tokenInfo base on chronik handle some feedback about scan & specific amount
eric-son12
reviewed
Mar 23, 2023
}; | ||
} | ||
// else if(this.addressbook && tx.inputAddresses[0] && this.getContactName(tx.inputAddresses[0])){ | ||
// return { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unuse code
* master: improve performance home card refactor code handle some feedback fix asset to build android handle some case show get started page not correct polish ui scan eToken fix bug scan eToken some case add command to build android handle some case scan eToken change model for tokenInfo base on chronik handle some feedback about scan & specific amount # Conflicts: # src/app/pages/wallet-details/wallet-details.ts # src/assets/i18n/en.po
* master: handle some feedback handle feedback primary account & scan refactor code polish home card & handle scan error handle feedback primary account # Conflicts: # src/app/pages/home/home.ts # src/theme/dark.scss
* master: (40 commits) date time format pump version fix comment handle virtual & uid add cmd build android revert code update version firebase messaging test crash app android hotfix android notification fix notification android build push notification change change cmd package edit translate vi edit vi translate refactor code polish ui & add translate vi marketing board handle build android for location service remove unused code refactor code change condition ... # Conflicts: # package-lock.json # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.