[go: up one dir, main page]
Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[iOS] Protect inner _styles, _attributes and copy them for returning … #2111

Merged
merged 1 commit into from
Feb 12, 2019
Merged

[iOS] Protect inner _styles, _attributes and copy them for returning … #2111

merged 1 commit into from
Feb 12, 2019

Conversation

wqyfavor
Copy link
Member

…values.

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@wqyfavor wqyfavor mentioned this pull request Feb 11, 2019
Closed
@weex-bot
Copy link
weex-bot commented Feb 11, 2019 •
edited
Loading
Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

jianhan-he
jianhan-he reviewed Feb 12, 2019
View reviewed changes
Copy link
Contributor
@jianhan-he jianhan-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doumafang
doumafang approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member
@doumafang doumafang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@doumafang doumafang merged commit a3111ee into apache:master Feb 12, 2019
@wqyfavor wqyfavor deleted the fix-transition-crash branch February 12, 2019 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jianhan-he jianhan-he jianhan-he left review comments

@doumafang doumafang doumafang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wqyfavor @weex-bot @doumafang @jianhan-he