[go: up one dir, main page]

Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[iOS] Add keyboardSize in "keyboard" event. #1620

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

wqyfavor
Copy link
Member
@wqyfavor wqyfavor commented Oct 8, 2018

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link
weex-bot commented Oct 8, 2018
Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

@cxfeng1-zz cxfeng1-zz merged commit e13b599 into apache:master Oct 9, 2018
wqyfavor added a commit to wqyfavor/incubator-weex that referenced this pull request Oct 9, 2018
cxfeng1-zz pushed a commit that referenced this pull request Oct 9, 2018
* [iOS] Protect instance from being rendered twice.

* [iOS] Add keyboardSize in "keyboard" event. (#1620)
@wqyfavor wqyfavor deleted the add-keyboard-size branch November 23, 2018 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants