[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Webhook #680

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

gerynugrh
Copy link
@gerynugrh gerynugrh commented Sep 15, 2024

RFC

To Clarify:

  1. When will we send webhook? For each email being received by addy, or for any outgoing email as well?
  2. Depending on (1) should we do both incoming and outgoing in a single PR or should we split it?
  3. Is there an existing design for the webhook payload?
  4. Should we be sending an email for every failed webhook? This would be quite spammy, I guess it's okay if we limit to only send it once a day? Benchmarking from other services, they usually have circuit breaker to stop the service from sending any webhook if it keeps responding with failure

Todo:

  • Webhook sending portion
  • Use spatie for signature and flow control (see more)

To consider:

  1. Which queue should we use, is internal queue okay or should we opt for external one, e.g Redis? I notice we already have an existing queue backed by redis, I will follow the existing implementation
  2. Should we allow both http and https or only https?

@gerynugrh gerynugrh marked this pull request as draft September 15, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant