Convert java.util.concurrent.TimeUnit to kotlin.time.Duration #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veyndan
commented
Mar 2, 2023
paging/paging-common/api/current.txt
Outdated
| @@ -134,7 +134,7 @@ package androidx.paging { | |||
| } | |||
|
|
|||
| public enum LoadType { | |||
| method public static androidx.paging.LoadType valueOf(String value) throws java.lang.IllegalArgumentException, java.lang.NullPointerException; | |||
| method public static androidx.paging.LoadType valueOf(String name) throws java.lang.IllegalArgumentException, java.lang.NullPointerException; | |||
There was a problem hiding this comment.
This API change (along with the others) seems to just be a reversion of 110d3a7 from a couple of days ago. I was prompted to run ./gradlew updateApi which resulted in these changes.
There was a problem hiding this comment.
Any chance you can try to rebase and re-run? GitHub got out of sync for metalava build (which does our api tracking) over night, but should be fixed now.
There was a problem hiding this comment.
Rebased! Thanks – after running ./gradlew updateApi again, it undid all the supposed API changes.
94da6ec
to
ba434ca
Compare
ianhanniballake
approved these changes
Mar 3, 2023
claraf3
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: ./gradlew test connectedCheck
Bug: 270612487