[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FragmentStrictMode] Detect wrong Fragment container usage #146

Closed
wants to merge 1 commit into from
Closed

[FragmentStrictMode] Detect wrong Fragment container usage #146

wants to merge 1 commit into from

Conversation

simonschiller
Copy link
Contributor

Proposed Changes

  • Detect usage of Fragment containers other than FragmentContainerView

Testing

Test: See FragmentStrictModeTest#detectWrongFragmentContainer

Issues Fixed

Fixes: 181137036

@google-cla google-cla bot added the cla: yes label Mar 22, 2021
@simonschiller simonschiller force-pushed the feature/wrong-fragment-container branch from 8fbe22e to 23a24fc Compare March 23, 2021 08:06
@simonschiller simonschiller force-pushed the feature/wrong-fragment-container branch from 23a24fc to cd84de8 Compare March 25, 2021 07:58
@dlam dlam requested a review from jbw0033 March 25, 2021 19:11
jbw0033
jbw0033 approved these changes Mar 29, 2021
View reviewed changes
Copy link
@jbw0033 jbw0033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing all of these. We are ready to make the APIs public now. Do you want to a change for removing the RestrictTo() annotations?

@simonschiller
Copy link
Contributor Author
simonschiller commented Mar 30, 2021 •
edited
Loading

Happy to help 😄
Sure, I can open a follow-up CL after this one is merged.

@simonschiller simonschiller deleted the feature/wrong-fragment-container branch March 31, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbw0033 jbw0033 jbw0033 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonschiller @jbw0033