Close caption menu with the Unknown label for the Português language #988
Comments
|
Hello @elimasword, The Format.language in that section of code from your screencapture shouldn't have "português" as that is not a valid IETF BCP 47 language tag. It should be "pt". I tested that if the format.language was "pt" then languageLocale.getDisplayName would return "português". Can I ask what media you are trying to play and if you may provide it? It may be that the media is providing an incorrect language tag value in its manifest or container. |
|
@microkatz Ok yes, we have an issue there but shouldn't in these cases where the |
Issue: #988 PiperOrigin-RevId: 606193299
Issue: androidx/media#988 PiperOrigin-RevId: 606193299
Issue: androidx#988 PiperOrigin-RevId: 606193299 (cherry picked from commit 0b0c419)
|
A commit was pushed that should hopefully address your issue! If the language name's display name is not identified, then a modified string is provided which includes the language name. Hopefully this helps your use case! It was released in 1.3.1. If not then please open up a new issue. Thanks! |
Version
Media3 1.2.0
More version details
No response
Devices that reproduce the issue
Pixel 6 running Android 14
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Not tested
Reproduction steps
In my application, we are creating a fullscreen player view where we create a builder of the exoplayer and pass the media that we want to play into it. In that media, we have close captions in two languages, we have English and Português.
When the player is loaded and I click on the close captions button to open the menu to select the languages I get the options "None", "English" and "Unknown", this last one is not correct.
After doing some debugging, I noticed that in the
DefaultTrackNameProviderexisted this chunk of code in which the returning language string is emptyIs it possible for the fallback here to be the
format.languagevalue and not an empty language, and rely on the values of the language labels defined in the captions of the media?Expected result
Have the correct language labels in the menu of the close captions
Actual result
Have the "Unknown" label for "Português" language
Media
Bug Report
adb bugreportto android-media-github@google.com after filing this issue.The text was updated successfully, but these errors were encountered: