[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multidex dependency #499

Closed
dellisd opened this issue Jul 5, 2023 · 2 comments
Closed

Remove multidex dependency #499

dellisd opened this issue Jul 5, 2023 · 2 comments
Assignees
@tonihei
Labels
bug

Comments

@dellisd
Copy link
dellisd commented Jul 5, 2023 •
edited
Loading

The multidex artifact was added as a dependency of every androidx.media3 library module in this commit (889f435), which I understand was to simplify the configuration for the demo apps. This adds an unnecessary transitive dependency on the multidex artifact for apps that do not require it however.
@tonihei tonihei self-assigned this Jul 6, 2023
@tonihei
Copy link
Collaborator
tonihei commented Jul 6, 2023

Thanks for reporting! This dependency was actually meant to be androidTestImplementation and not implementation, so that it gets automatically included in all instrumentation test builds.

@tonihei
Copy link
Collaborator
tonihei commented Jul 6, 2023

You can also manually exclude this dependency for now by using

implementation('androidx.media3:media3-exoplayer:1.1.0') {
  exclude group: 'androidx.multidex', module: 'multidex'
}

rohitjoins pushed a commit that referenced this issue Jul 14, 2023
@tonihei @rohitjoins
Change multidex dependency type to androidTestImplementation
2250ffe 
This is only needed for instrumentation tests and should not
be included in regular builds.

#minor-release

Issue: #499
PiperOrigin-RevId: 545913113
rohitjoins pushed a commit to google/ExoPlayer that referenced this issue Jul 14, 2023
@tonihei @rohitjoins
Change multidex dependency type to androidTestImplementation
776abb5 
This is only needed for instrumentation tests and should not
be included in regular builds.

#minor-release

Issue: androidx/media#499
PiperOrigin-RevId: 545913113
@tonihei tonihei closed this as completed Jul 18, 2023
tianyif pushed a commit to google/ExoPlayer that referenced this issue Aug 11, 2023
@tonihei @tianyif
Change multidex dependency type to androidTestImplementation
63cf71d 
This is only needed for instrumentation tests and should not
be included in regular builds.

#minor-release

Issue: androidx/media#499
PiperOrigin-RevId: 545913113
(cherry picked from commit 776abb5)
tianyif pushed a commit that referenced this issue Aug 14, 2023
@tonihei @tianyif
Change multidex dependency type to androidTestImplementation
9de5684 
This is only needed for instrumentation tests and should not
be included in regular builds.

Issue: #499
PiperOrigin-RevId: 545913113
(cherry picked from commit 2250ffe)
tianyif pushed a commit to google/ExoPlayer that referenced this issue Aug 14, 2023
@tonihei @tianyif
Change multidex dependency type to androidTestImplementation
8fbb224 
This is only needed for instrumentation tests and should not
be included in regular builds.

#minor-release

Issue: androidx/media#499
PiperOrigin-RevId: 545913113
(cherry picked from commit 776abb5)
@androidx androidx locked and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tonihei tonihei

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dellisd @tonihei