feat(provider): LRUCache Layer #954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jun 22, 2024
mattsse
requested changes
Jun 24, 2024
mattsse
reviewed
Aug 21, 2024
|
Decided to make this a provider-layer, this lets us achieve two very important features that wouldn't work as a transport layer:
To accomplish this we need to merge #788 |
yash-atreya
commented
Sep 24, 2024
crates/provider/src/layers/cache.rs
Outdated
| let cache = CacheLayer::new(100); | ||
| let anvil = Anvil::new().block_time_f64(0.3).spawn(); | ||
| let provider = ProviderBuilder::default() | ||
| // .with_recommended_fillers() - TODO: Issue here. Layer doesn't work with fillers. Fix. |
There was a problem hiding this comment.
Enabling fillers would wrap the CacheProvider or any other layer provider in a FillProvider. Making methods on CacheProvider inaccessible. i.e provider.load_cache(path) won't work but provider.inner.load_cache(path) works.
This is not ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ref: #770
Solution
WIP
keyis the hash of the serialized request params.TODO
save_cacheandload_cachevia provider.PR Checklist