fix(stages): set healthy status for promotions w/o checks #2951
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2951 +/- ##
==========================================
- Coverage 50.92% 50.91% -0.01%
==========================================
Files 279 279
Lines 25180 25175 -5
==========================================
- Hits 12823 12818 -5
Misses 11666 11666
Partials 691 691 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
d9773cd
to
653339d
Compare
| // If the last Promotion did not succeed, then we cannot perform any health | ||
| // checks because they are only available after a successful Promotion. | ||
| // | ||
| // TODO(hidde): Long term, this should probably be changed to allow to | ||
| // continue to run health checks from the last successful Promotion, | ||
| // even if the current Promotion did not succeed (e.g. because it was | ||
| // aborted). |
There was a problem hiding this comment.
We discussed offline and agreed that this is the right thing to do in the near-term and longer-term it would be nice to try to run whatever health checks were specified by the last successful promotion. This would likely involve copying health checks over to the Freight reference at the top of the Freight history stack.
This LGTM for now.
|
Double checking this solves all reported issues before merging. |
Follow up to #2905