forked from flameshot-org/flameshot
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
e824ee7
commit 008aca8
Showing
1 changed file
with
98 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,52 +1,140 @@ | ||
| # Add an opacity slider for colour-picker | ||
|
|
||
| ## To be Reviewed By: | ||
| ### To be Reviewed By | ||
|
|
||
| ### Authors: | ||
| * borgmanJeremy | ||
| * mmahmoudian | ||
| * Flameshot developers | ||
|
|
||
| ### Status: ~~Draft | Discussion |~~ Active ~~| Dropped | Superseded~~ | ||
| ### Authors | ||
|
|
||
| * Pr. Sunflower | ||
|
|
||
|
|
||
| <br> | ||
|
|
||
| ### Status: Draft ~~| Discussion | Active | Dropped | Superseded~~ | ||
|
|
||
| [Pr. Sunflower] This is the first time the authors are redacting a document of this sort and they kindly request to double-check their writings and to assist them in missing parts. | ||
|
|
||
|
|
||
| <br> | ||
|
|
||
| ### Superseded by | ||
|
|
||
| N/A | ||
|
|
||
| ### Related | ||
|
|
||
| * Issue #249 | ||
| * Issue #1085 | ||
|
|
||
| Superseded by: N/A | ||
|
|
||
| Related: Issue #249 | ||
|
|
||
| <br> | ||
|
|
||
| ## Problem | ||
|
|
||
| What is this proposal solving? Why does the problem matter? How does the problem affect the user? | ||
| Currently the drawing and marking tools in Flameshot only have one, non-customisable opacity setting. This current setting is bad for highlighting text because the Marker tool looks very pale. To compensate the user often has to highlight multiple times which is not convenient and time-consuming. | ||
|
|
||
| Here is a comparison of Flameshot's Marker tool with Microsoft's **Snip & Sketch** Highlighter tool: | ||
|
|
||
| ### Black text on light background | ||
|
|
||
| **Flameshot:** | ||
|  | ||
|
|
||
| **Snip & Sketch:** | ||
|  | ||
|
|
||
| <br> | ||
|
|
||
| ### White text on dark background | ||
|
|
||
| **Flameshot:** | ||
|  | ||
|
|
||
| **Snip & Sketch:** | ||
|  | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| <br> | ||
|
|
||
| <br> | ||
|
|
||
| ## Anti-Goals | ||
|
|
||
| What is outside the scope of what the proposal is trying to solve? | ||
| The Marker tool does a very good job at keeping the text readable so this is not linked to this request. | ||
|
|
||
|  | ||
|
|
||
|  | ||
|
|
||
|
|
||
|
|
||
|
|
||
| <br> | ||
|
|
||
| <br> | ||
|
|
||
| ## Solution | ||
|
|
||
| Describe your solution and how it’s going to solve the problem. This is likely the largest section of your proposal and might even include some high-level diagrams if you are proposing code changes. While all important aspects need to be covered, also keep in mind that shorter documents are more likely to be read. | ||
| Changes and Additions to Public Interfaces | ||
| **Add a way to control opacity, like an opacity slider in the Tool Settings.** | ||
|
|
||
| If you are proposing to add or modify public interfaces, those changes should be outlined here in detail. | ||
| Add an opacity slider under "Active thickness". | ||
|
|
||
|  | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| <br> | ||
|
|
||
| <br> | ||
|
|
||
| ## Performance Impact | ||
|
|
||
| [Pr. Sunflower:] *I need help for this part.* | ||
|
|
||
| Do you anticipate the proposed changes to impact performance in any way? Are there plans to measure and/or mitigate the impact? | ||
|
|
||
|
|
||
| <br> | ||
|
|
||
| ## Backwards Compatibility and Upgrade Path | ||
|
|
||
| [Pr. Sunflower:] *I need help for this part.* | ||
|
|
||
| Will the regular rolling upgrade process work with these changes? | ||
|
|
||
| How do the proposed changes impact backwards-compatibility? Are message or file formats changing? | ||
|
|
||
| Is there a need for a deprecation process to provide an upgrade path to users who will need to adjust their applications? | ||
|
|
||
| <br> | ||
|
|
||
| ## Prior Art | ||
|
|
||
| [Pr. Sunflower:] *I don't think this part is useful.* | ||
|
|
||
| What would be the alternatives to the proposed solution? What would happen if we don’t solve the problem? Why should this proposal be preferred? | ||
|
|
||
| <br> | ||
|
|
||
| ## FAQ | ||
|
|
||
| [Pr. Sunflower:] *I need help for this part.* | ||
|
|
||
| Answers to questions you’ve commonly been asked after requesting comments for this proposal. | ||
|
|
||
| <br> | ||
|
|
||
| ## Errata | ||
|
|
||
| [Pr. Sunflower:] *I need help for this part.* | ||
|
|
||
| What are minor adjustments that had to be made to the proposal since it was approved? |