[go: up one dir, main page]
Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

feat: add plugin support for downstream pipelines #141

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: add plugin support for downstream pipelines #141

wants to merge 1 commit into from

Conversation

jortega0
Copy link
@jortega0 jortega0 commented Oct 12, 2023 •
edited
Loading

This PR adds the ability to provide the plugins keyword to individual downstream buildkite jobs. This is needed so that we can use other plugins for downstream jobs that monorepo-diff-buildkite-plugin is using.

    plugins:
      - monebag/monorepo-diff#v2.5.8:
          ...
          watch:
            - path:
                - "foo/**"
              config:
                ...
                plugins:
                  - seek-oss/aws-sm#v2.3.1:
                      env:
                        AUTH_SECRET:
                          secret-id: "secret/id"
                          json-key: ".key"
            - path:
                - "bar/**"
              config:
                ...
                plugins:
                  - seek-oss/aws-sm#v2.3.1:
                      env:
                        AUTH_SECRET:
                          secret-id: "secret/id2"
                          json-key: ".key2"

See #142 for more information on the problem.

  • TODO: Add unit tests
  • TODO: Update Readme examples

@jortega0 jortega0 closed this Oct 12, 2023
@jortega0 jortega0 reopened this Oct 13, 2023
@jortega0 jortega0 changed the title Jortega0/test buildkite plugin Add plugin support for downstream piplines Oct 13, 2023
@jortega0 jortega0 marked this pull request as draft October 13, 2023 13:19
@jortega0 jortega0 force-pushed the jortega0/test-buildkite-plugin branch from 7ced608 to 4dfcb0c Compare October 13, 2023 13:22
@jortega0 jortega0 closed this Oct 13, 2023
@jortega0 jortega0 force-pushed the jortega0/test-buildkite-plugin branch from 4dfcb0c to 3f65d09 Compare October 13, 2023 13:26
@jortega0 jortega0 reopened this Oct 13, 2023
@jortega0 jortega0 changed the title Add plugin support for downstream piplines feat: add plugin support for downstream piplines Oct 13, 2023
@jortega0 jortega0 changed the title feat: add plugin support for downstream piplines feat: add plugin support for downstream pipelines Oct 18, 2023
@mbarrien
Copy link

This PR is also necessary to get https://github.com/buildkite/agent-stack-k8s working in combination with monorepo plugin. Please review soon!

@anherrera
Copy link

Any update on getting this shipped? My org could benefit from this! Thank you :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jortega0 @mbarrien @anherrera