[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: support rails authentication generator out of the box #3376

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor: support rails authentication generator out of the box #3376

wants to merge 2 commits into from
+42 −32

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes #3361

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Generate a new Rails 8 app
  2. Run the authentication generator bin/rails generate authentication
  3. check to see if Avo has the sign out button available

Manual reviewer: please leave a comment with output from the test if that's the case.

@codeclimate CodeClimate
Copy link
codeclimate bot commented Nov 1, 2024 •
edited
Loading

Code Climate has analyzed commit a79a20c and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev mentioned this pull request Nov 1, 2024
Merged
4 tasks
@adrianthedev adrianthedev marked this pull request as ready for review November 1, 2024 19:16
@adrianthedev adrianthedev mentioned this pull request Nov 1, 2024
Open
11 tasks
@adrianthedev adrianthedev changed the title refactor: support rails authentication out of the box refactor: support rails authentication generator out of the box Nov 4, 2024
@adrianthedev adrianthedev marked this pull request as draft November 4, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Paul-Bob Paul-Bob Awaiting requested review from Paul-Bob

Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrating Rails 8 authentication with Avo
1 participant
@adrianthedev