[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrabiata: start the permutation argument interface #2593

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Arrabiata: start the permutation argument interface #2593

wants to merge 5 commits into from

Conversation

dannywillems
Copy link
Member

No description provided.

@dannywillems dannywillems marked this pull request as draft September 23, 2024 17:15
@dannywillems dannywillems force-pushed the dw/arrabiata-perm-arg branch 2 times, most recently from e400e32 to 1b1459d Compare October 8, 2024 15:53
@codecov Codecov
Copy link
codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 8.33333% with 33 lines in your changes missing coverage. Please review.

Project coverage is 72.47%. Comparing base (b993283) to head (b5b7a0d).
Report is 63 commits behind head on master.

Files with missing lines Patch % Lines
arrabiata/src/witness.rs 3.22% 30 Missing ⚠️
arrabiata/src/constraints.rs 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2593      +/-   ##
==========================================
- Coverage   72.60%   72.47%   -0.13%     
==========================================
  Files         246      246              
  Lines       58154    58274     +120     
==========================================
+ Hits        42220    42235      +15     
- Misses      15934    16039     +105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dannywillems
Arrabiata: start the permutation argument interface
7e5bbae
@dannywillems
WIP: attempt to use hashmap? Not sure it is good.
38f4d0d 
I have been thinking about a memory that has to be initialized first, and use
some interface like RAMlookup to access values, and the protocol is simply
different.
@dannywillems
fixup! WIP: attempt to use hashmap? Not sure it is good.
83b5d91
@dannywillems
Arrabiata: remove "permutation" gadget
297772f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dannywillems