feat: remove broken accounts and auth in ui SOFIE-3326 #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/vite-ui-bundler2 #1241 +/- ##
=========================================================
+ Coverage 83.48% 83.56% +0.08%
=========================================================
Files 173 173
Lines 30650 30650
Branches 2622 2631 +9
=========================================================
+ Hits 25588 25614 +26
+ Misses 5035 5011 -24
+ Partials 27 25 -2 ☔ View full report in Codecov by Sentry. |
nytamin
approved these changes
Aug 19, 2024
Base automatically changed from
feat/vite-deduplicate-meteor-lib
to
feat/vite-ui-bundler2
August 26, 2024 10:06
An error occurred while trying to automatically change base from
feat/vite-deduplicate-meteor-lib
to
feat/vite-ui-bundler2
August 26, 2024 10:06
1e75aaa
to
92c6fe1
Compare
92c6fe1
to
a067afe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a: Code improvement
New Behavior
#1230 breaks the authentication implementation in the ui.
This PR removes the auth pages and other bits of implementation, instead of leaving it in a broken state.
This intentionally does not touch the implementation in the backend, portions of that may prove more useful to implement better auth
We are open to this being re-implemented, but we don't see the value of it in its prior form.
Testing
Affected areas
Time Frame
Other Information
Status