[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Failed to parse git url #60

Closed
link89 opened this issue Feb 26, 2020 · 1 comment
Closed

[BUG] Failed to parse git url #60

link89 opened this issue Feb 26, 2020 · 1 comment
Milestone
OSS - Sprint 5

Comments

@link89
Copy link
link89 commented Feb 26, 2020 •
edited
Loading

Hi, I think the new version just breaks the git URL parser.

hosted-git-info/index.js

Line 112 in 6f39e93

var whatwg = new url.URL(giturl)

Now it failed to handle dependency like this:
git+ssh://git@git.unlucky.com:RND/electron-tools/some-tool#2.0.1

Can you release a hotfix for this? It breaks a lot of things and hard to work around in projects.

node version: 12.0.0

@isaacs
@darcyclarke
@isaacs
Copy link
Contributor
isaacs commented Feb 26, 2020

Confirmed, we'll take a look at this today.

@darcyclarke darcyclarke added this to the OSS - Sprint 5 milestone Feb 26, 2020
isaacs added a commit that referenced this issue Feb 26, 2020
@isaacs
fix: Do not pass scp-style URLs to the WhatWG url.URL
01ee700 
Fix #60
isaacs added a commit that referenced this issue Feb 26, 2020
@isaacs
fix: Do not pass scp-style URLs to the WhatWG url.URL
f2cdfcf 
Fix #60 (for the legacy branch)
This was referenced Feb 26, 2020
Closed
Closed
billneff79 added a commit to billneff79/hosted-git-info that referenced this issue Feb 26, 2020
@billneff79
fix: do not use url.URL to support early node 6 and scp-style URLs
2dedc7b 
fix npm#60 and npm#61
@billneff79 billneff79 mentioned this issue Feb 26, 2020
Closed
@isaacs isaacs closed this as completed in 0835306 Feb 26, 2020
@pniewiejski pniewiejski mentioned this issue Feb 28, 2020
Closed
@JACKEYBANKZ JACKEYBANKZ mentioned this issue Oct 24, 2021
Open
@sync-by-unito sync-by-unito bot mentioned this issue Mar 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OSS - Sprint 5
Development

Successfully merging a pull request may close this issue.

fix: Do not pass scp-style URLs to the WhatWG url.URL npm/hosted-git-info
3 participants
@isaacs @darcyclarke @link89