feat(dashboard): Add pause modal #7046
Open
+63
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
52db1a2
to
2d2bb0a
Compare
rifont
reviewed
Nov 18, 2024
apps/dashboard/src/components/workflow-editor/configure-workflow.tsx
Outdated
Show resolved
Hide resolved
SokratisVidros
approved these changes
Nov 18, 2024
| @@ -12,3 +12,6 @@ export const EXCLUDED_EDITOR_TYPES: string[] = [ | |||
| StepTypeEnum.TRIGGER, | |||
| StepTypeEnum.CUSTOM, | |||
| ]; | |||
|
|
|||
| export const PAUSE_MODAL_TITLE = 'Proceeding will pause the workflow'; | |||
| export const PAUSE_MODAL_DESCRIPTION = 'This workflow cannot be triggered if paused, please confirm to proceed.'; | |||
There was a problem hiding this comment.
Suggested change
| export const PAUSE_MODAL_DESCRIPTION = 'This workflow cannot be triggered if paused, please confirm to proceed.'; | |
| export const PAUSE_MODAL_DESCRIPTION = 'The ${workflowName} cannot be triggered if paused, please confirm to proceed.'; |
| @@ -237,7 +251,16 @@ export const WorkflowRow = ({ workflow }: WorkflowRowProps) => { | |||
| </DropdownMenuGroup> | |||
| <DropdownMenuSeparator /> | |||
| <DropdownMenuGroup className="*:cursor-pointer"> | |||
| <DropdownMenuItem disabled={workflow.status === WorkflowStatusEnum.ERROR}> | |||
| <DropdownMenuItem | |||
| => { | |||
There was a problem hiding this comment.
Prefer to make this an onClick handler function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Screen.Recording.2024-11-18.at.4.34.36.PM.mov
Expand for optional sections
Related enterprise PR
Special notes for your reviewer