Group nodes - Alpha #3713
Merged
Group nodes - Alpha #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also start of updating upon Group tree changes
Instead of creating extra property it is simple just replace node id to make it unique when it processed from different group nodes Also now editing group tree will update only current its instance so it could be debug easily
remove throttling group tree
|
Playing around canceling group tree update. It's not efficient to color each node which is currently updating in case if updation is going quite rapidly. But if to skip coloring some nodes when really hard node will be get it's quite likely that it won't be colored as updating node. So probably it would be better to color already updated nodes instead. Or not coloring nodes at all but potentially this functionality can be very user friendly and explorative about what is actually going on. |
and fixing some bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed problem description
This PR should bring life into group nodes.
It's not a final stage and future updates can break work of saved trees with group nodes.
For now every node which connected to group output node or to other nodes which connected to group output node will be evaluated. Also Debug print and Stethoscope nodes are supported.
Editing the same node groups from different windows is unsupported.
Viewer nodes inside ndoe groups are not supported.
fixing #3660
#3319
Preflight checklist