New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up orphaned editors #4821

Merged

knolleary merged 1 commit into master from orphaned-monco-editors

Jul 1, 2024

Contributor

Steve-Mcl commented

closes #4820

Types of changes

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Proposed changes

call editor.dispose at end of destroy call
iterate any editors not in DOM and call dispose

Checklist

I have read the contribution guidelines
For non-bugfix PRs, I have discussed this change on the forum/slack team.
I have run npm run test to verify the unit tests pass
I have added suitable unit tests to cover the new/changed functionality


          Clean up orphaned editors

closes #4820

knolleary merged commit 785f220 into master

4 checks passed

knolleary deleted the orphaned-monco-editors branch

July 1, 2024 09:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet