Add fish completions, update documentation accordingly #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @nucleogenesis ! I have bypassed CI because drone appears to have grinded to a halt. The service, and the company, due to the acquisition no doubt. It works locally. I'll have to get round to moving to github actions soon, and perhaps not vendor modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159
The fish shell's completions docs expect a space-separated list of completions. Piping
dtask _completionsinto the fish utilitystring-collectappears to do exactly what is needed to setup the completions.Testing
fishto enter a fish shellmake dist/dstaskdist/dstask fish-completion | sourcedist/dstask show-and see now that the completions work in FishReviewer guidance
Have I missed anything? I basically just grepped for "bash" and then copy-pasted the seemingly relevant lines changed "bash" to "fish".
I've also updated the documentation to show multiple examples -- one each for bash, zsh and fish. I felt this would be particularly helpful for fish users as the
<()operation doesn't work in fish:fish: Invalid redirection target: source <(dist/dstask _completions)Happy to tweak it as necessary.