[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two additional valid http methods: HEAD and OPTIONS #33

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Add two additional valid http methods: HEAD and OPTIONS #33

merged 1 commit into from
Oct 21, 2020

Conversation

abstrctn
Copy link

Hoping to use this to test an OPTIONS request, and noticed both of these methods were excluded during validation. I tested it locally and the http library doesn't seem to have any trouble handling them.

@abstrctn abstrctn requested a review from a team as a code owner October 21, 2020 18:51
@abstrctn abstrctn requested review from akhenakh, tonglil and shawn620 and removed request for a team October 21, 2020 18:51
shawn620
shawn620 approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor
@shawn620 shawn620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@shawn620 shawn620 merged commit fb7c236 into nytimes:master Oct 21, 2020
@tonglil tonglil added the enhancement New feature or request label Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn620 shawn620 shawn620 approved these changes

@akhenakh akhenakh Awaiting requested review from akhenakh

@tonglil tonglil Awaiting requested review from tonglil

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abstrctn @shawn620 @tonglil