[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Changelog LatestVersion Property #1240

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Fix Changelog LatestVersion Property #1240

wants to merge 10 commits into from

Conversation

sandrofigo
Copy link
Contributor
@sandrofigo sandrofigo commented Aug 27, 2023 •
edited
Loading

This PR fixes the LatestVersion property on the Changelog class, adds unit tests to validate the desired behavior and fixes some typos. Includes changes from #1250

Before Fix

# Changelog
## [Unreleased]
### Added
- Some text

## [1.0.0] - 2023-02-03
### Added
- Added something

## [0.5.3] - 2023-01-02 <--- `LatestVersion` would return "0.5.3"
### Fixed
- Fixed something

After Fix

# Changelog
## [Unreleased]
### Added
- Some text

## [1.0.0] - 2023-02-03 <--- `LatestVersion` now returns "1.0.0"
### Added
- Added something

## [0.5.3] - 2023-01-02
### Fixed
- Fixed something

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@sandrofigo sandrofigo force-pushed the fix-changelogtasks-latestversion branch 2 times, most recently from 91d7bea to aab0ce6 Compare September 5, 2023 07:11
@matkoch matkoch force-pushed the develop branch 5 times, most recently from 0231425 to d806295 Compare December 15, 2023 23:12
@matkoch matkoch force-pushed the develop branch 3 times, most recently from 7066bbe to 985de83 Compare January 17, 2024 17:25
@sandrofigo sandrofigo force-pushed the fix-changelogtasks-latestversion branch from aab0ce6 to 3fdc876 Compare March 4, 2024 07:32
@sandrofigo sandrofigo force-pushed the fix-changelogtasks-latestversion branch from 3fdc876 to 83570fb Compare March 5, 2024 19:29
@matkoch matkoch force-pushed the develop branch 4 times, most recently from 0719711 to 6fe1e3b Compare March 20, 2024 01:24
@matkoch matkoch force-pushed the develop branch 2 times, most recently from 6d02194 to 4bfee84 Compare June 13, 2024 21:33
@matkoch matkoch force-pushed the develop branch 3 times, most recently from 85998da to 01b2b6e Compare July 9, 2024 00:20
@matkoch matkoch force-pushed the develop branch 3 times, most recently from e652c9a to 6ed9e4d Compare July 14, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandrofigo @matkoch