fix: disable mutation observing when not supported #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable mutation observing and display a message when MutationObserver is not supported by the browser. Closes michalsnik#404
michalsnik
approved these changes
Oct 3, 2018
There was a problem hiding this comment.
Thanks for the PR! It looks good to me 👍 I’m also aware of how the process or developing two versions simultanosly should look like :) I just wasn’t that active recently due to other projects I’m participating in and other stuff. The PR with disableMutationObserver was created while I was working on the “next” branch before releasing it, hence it got to master, and then I didn’t forget to pull this to next. I’m happily accepting PR’s to v2 branch but only with bug fixes and small features (until I release v3 officially, then only bug fixes). Every other PR should land on „next”.
Closed
michalsnik
pushed a commit
that referenced
this pull request
Oct 3, 2018
Disable mutation observing and display a message when MutationObserver is not supported by the browser. Closes #404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #404
Your solution
Disable mutation observing and display a message when MutationObserver is not supported by the browser.
How Has This Been Tested?
npm run buildnpm test(all tests passed)Note
When preparing a new version, the
nextversion should always be ahead of the past versions. When bugfixes are or new features are added, they should be made in priority on thenextversion, and duplicated on older versions for long-term support and quick-release purposes. Older versions should not contains features or fixes thenextversion does not have. This way, no regression will be made when releasing thenextversion.I tried to provide the same fix for the
nextbranch, but thedisableMutationObserveris not implemented on it. This is a real problem with the development workflow of this project. I would recommend you to take a look at the Foundation Contributing Guidelines that explains how we deal with the parallel development of several versions.