[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #687 Add skip to content button #1235

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

evelinabe
Copy link
Contributor
@evelinabe evelinabe commented Jun 20, 2024

Skip to content button added. It does not work so well on the first page - it is the first item in the navigation order, but the focus is set to the popover button. Let me know what you think, and if there's something in the code that needs updating.

Resolves issue #687

Copy link
changeset-bot bot commented Jun 20, 2024

⚠️ No Changeset found

Latest commit: 0540c17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@evelinabe evelinabe changed the title Add skip to content button #687 Add skip to content button Jun 20, 2024
@evelinabe evelinabe changed the title #687 Add skip to content button Resolves #687 Add skip to content button Jun 20, 2024
Copy link
Contributor
github-actions bot commented Jun 27, 2024
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
melt-ui ✅ Ready (View Log) Visit Preview 0540c17

@TGlide
Copy link
Member
TGlide commented Jun 27, 2024

Hey, thank you for the PR!

It seems the button isn't visible when focusing it. I can see in the console that it is focused, but nonetheless there is no visual indication. At least in the cloudflare preview!

@evelinabe
Copy link
Contributor Author
evelinabe commented Jun 27, 2024

It seems the button isn't visible when focusing it. I can see in the console that it is focused, but nonetheless there is no visual indication. At least in the cloudflare preview!

I noticed that, too, I had a look at the preview. It needed a higher z-index, I already pushed that change

@TGlide
Copy link
Member
TGlide commented Jun 28, 2024

Hmm, the new preview still fails. I don't think z-1000 is a valid tailwind class, you may need to do z-[1000]

@evelinabe
Copy link
Contributor Author

Strange, it works on my machine 🤔
Giving it another go 🤞

@TGlide
Copy link
Member
TGlide commented Jun 28, 2024

Awesome, it works now! Thank you so much for the contribution, and for putting up with the back and forth 😄

@TGlide TGlide merged commit ab699b1 into melt-ui:develop Jun 28, 2024
5 of 6 checks passed
@evelinabe
Copy link
Contributor Author

No problem, happy to help!

@evelinabe evelinabe deleted the 687-skip-to-content-button branch June 28, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants