chore: Add CI checks for prover directory
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
- Coverage 32.75% 32.70% -0.06%
==========================================
Files 536 536
Lines 28133 28135 +2
==========================================
- Hits 9216 9201 -15
- Misses 18917 18934 +17
☔ View full report in Codecov by Sentry. |
mm-zk
reviewed
Oct 12, 2023
mm-zk
reviewed
Oct 13, 2023
mm-zk
approved these changes
Oct 13, 2023
EmilLuta
reviewed
Oct 13, 2023
EmilLuta
reviewed
Oct 13, 2023
|
I thought we'd be renaming components as well between FRI and non-FRI. That said, it's not a blocker. I'd prefer if we "context"-ed all errors so we have a good trace. I know it's not part of this work, but would be great to be done alongside. This said, I'm a big fan of the work done, thanks for the effort! |
EmilLuta
approved these changes
Oct 13, 2023
yorik
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
proverdirectoryproverdirectoryprover/proverandprover/setup_key_generator_and_servercompilable without a GPU.ci_runscript (before, prover unit tests weren't being run at all)zktool to includezk lint proverandzk test proverWhy ❔
Following good practices & reducing technical debt.
Checklist
zk fmtandzk lint.