[sm] Add data exporter for ClickHouse in mdx file #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e515573
to
f58b835
Compare
mfreeman451
reviewed
Nov 23, 2023
| Specify your configuration settings in 'io_config.yaml'. | ||
|
|
||
| """ | ||
| database = 'database_name' # Specify the name of the schema to export data to |
There was a problem hiding this comment.
What about using mage secrets to store this, for this example?
| from mage_ai.data_preparation.decorators import data_exporter | ||
|
|
||
|
|
||
| class ClickHouse(ClickHouseParent): |
There was a problem hiding this comment.
you don't need to add this class if there's no customized logic in enter and exit methods.
Just do
ClickHouse.with_config(ConfigFileLoader(config_path, config_profile)).export(
....
)
in the method below
f58b835
to
a79f615
Compare
| config_path = path.join(get_repo_path(), 'io_config.yaml') | ||
| config_profile = 'default' | ||
|
|
||
| with ClickHouse.with_config(ConfigFileLoader(config_path, config_profile)) as loader: |
There was a problem hiding this comment.
I mean you don't need with statement.
just do
ClickHouse.with_config(ConfigFileLoader(config_path, config_profile)).export(
...
)
a79f615
to
fe51e87
Compare
wangxiaoyou1993
approved these changes
Dec 5, 2023
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add data exporter for ClickHouse in mdx file
Related Slack thread: https://mageai.slack.com/archives/C03HTTWFEKE/p1700653736340409
How Has This Been Tested?
Checklist
docs/mint.jsoncc: