-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dy] Optimize pipeline schedules LIST api #4058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dy46
force-pushed
the
dy--resolve_n+1_query_issue
branch
from
December 8, 2023 01:07
bc69a11
to
cea0691
Compare
dy46
force-pushed
the
dy--resolve_n+1_query_issue
branch
from
December 8, 2023 01:09
cea0691
to
c9b32c6
Compare
dy46
changed the title
[dy] Resolve pipeline schedules N+1 query issue
[dy] Optimize pipeline schedules LIST api
Dec 8, 2023
dy46
force-pushed
the
dy--resolve_n+1_query_issue
branch
from
December 8, 2023 18:10
47a9cb5
to
d3c82a8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how we fetch certain fields on the pipeline_schedules LIST endpoint. The
pipeline_runs_count
,pipeline_in_progress_runs_count
andtags
were all being fetched individually for every pipeline schedule that was being returned, so I changed the logic to instead fetch these fields once for all schedules.There doesn't seem to be a major performance improvement on the requests because the pipeline_schedule requests generally include a small limit for pagination purposes. I'm also not sure if my implementation of the queries is optimal, so there could be an issue there as well.
How Has This Been Tested?
Checklist
docs/mint.json
cc: @wangxiaoyou1993