[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compiler warning for possible uninitialized write_column_into_string #1622

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: compiler warning for possible uninitialized write_column_into_string #1622

merged 1 commit into from
Sep 30, 2024

Conversation

fedefrancescon
Copy link
Contributor

Compiling with -Werror=maybe-uninitialized causes the compiler to complain about an eventually possible use of unititialized write_colum_into_string function pointer.

mydumper/src/mydumper-0.16.7-5/src/mydumper_write.c:703:17: error: ‘write_column_into_string’ may be used uninitialized [-Werror=maybe-uninitialized]
  703 |                 write_row_into_string(conn, dbt, row, fields, lengths, num_fields, escaped, statement_row, write_column_into_string);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mydumper/src/mydumper-0.16.7-5/src/mydumper_write.c:637:10: note: ‘write_column_into_string’ was declared here
  637 |   void (*write_column_into_string)(MYSQL *, gchar **, MYSQL_FIELD , gulong ,GString *, GString *, struct function_pointer * );
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [CMakeFiles/mydumper.dir/build.make:342: CMakeFiles/mydumper.dir/src/mydumper_write.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:86: CMakeFiles/mydumper.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

@fedefrancescon
Copy link
Contributor Author

The CI seems to be failing on some env, but seems due to failure on setting up the test env

@davidducos davidducos added this to the Release 0.16.9-1 milestone Sep 30, 2024
@davidducos davidducos merged commit 22e41d9 into mydumper:master Sep 30, 2024
34 of 38 checks passed
@fedefrancescon fedefrancescon deleted the possible-uninitialized-write_column_into_string branch September 30, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
Release 0.16.9-1
Development

Successfully merging this pull request may close these issues.
2 participants
@fedefrancescon @davidducos