[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding jabber protocol #45

Merged
merged 7 commits into from
Sep 9, 2017
Merged

adding jabber protocol #45

merged 7 commits into from
Sep 9, 2017

Conversation

nassimabedi
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 99.573% when pulling efb55f7 on nassimabedi:master into 04e06aa on mushorg:master.

@nassimabedi
Copy link
Contributor Author

adding jabber protocol

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 99.573% when pulling dd3fc53 on nassimabedi:master into 04e06aa on mushorg:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 99.572% when pulling b94d5bd on nassimabedi:master into 04e06aa on mushorg:master.

@nassimabedi
Copy link
Contributor Author

Would you please describe about Coverage decreased.
This pull request works on my laptop!

@nikofil
Copy link
Collaborator
nikofil commented Sep 9, 2017

Nice work! If you can add a pcap file with some jabber flows, along with the expected number of flows to https://github.com/mushorg/go-dpi/blob/master/modules/classifiers/classifiers_test.go#L143, that should fix the coverage issue.
Also, could you run go fmt $(go list ./... | grep -v /vendor/) and see if there are formatting issues? Because I see e.g. in a couple places spaces instead of tabs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6ea2880 on nassimabedi:master into 04e06aa on mushorg:master.

@nassimabedi
Copy link
Contributor Author
nassimabedi commented Sep 9, 2017 •
edited
Loading

Thank you for your guidance 🙂
My result is different I found 10 jabber packet and travis found just one jabber packet:
This is my result:
Number of packets: 24 Number of packets identified: 13 Protocols identified: map[JABBER:10 DNS:3]
Also my results is different from the classifier_test in other protocols?!

@nikofil
Copy link
Collaborator
nikofil commented Sep 9, 2017

No, that's okay, the tests count flows while the app counts the individual packets. :)

@nikofil nikofil merged commit 24cb1ae into mushorg:master Sep 9, 2017
nikofil pushed a commit to nikofil/go-dpi that referenced this pull request Sep 9, 2017
@nassimabedi @nikofil
adding jabber protocol (mushorg#45)
d7e365b 
* adding jabber protocol

* adding pcap file for jabber

* remove line

* adding test capture file for jabber to TestClassifiers and modifying format

* debug jabber test

* rename jabber pcap file

* modifying classfires_test for jabber

Signed-off-by: Nikos Filippakis <aesmade@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nassimabedi @coveralls @nikofil