chore: update deps to latest #1594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zamiell
commented
Nov 8, 2024
| "prettier": "^3.3.3", | ||
| "ts-jest": "^29.2.5", | ||
| "ts-node": "^10.9.2", | ||
| "typescript": "5.6.3", |
There was a problem hiding this comment.
I removed the caret here, since having it here was a bug. (This should be kept exactly the same as what the peer dependency specifies.)
|
Sorry but for security reasons I'm not accepting external contributions messing with all of our deps, especially paired with a +1000-1000 change set |
|
can you update the deps then? it should be easy to replicate this pull request, just type the following: and then fix the typescript bug in package.json, and update the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deps were very old so this PR updates them to the latest.
Additionally, this fixes the big warning when running
npm run lint.Updating Prettier to latest required also running
npm run fix:prettier, which changed a lot of files.Please do a release after this PR so that end-users can solve the peer dependencies problem with TypeScript.