[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix duplicate list partition when partition name exceed (backport #51503) #51536

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[BugFix] Fix duplicate list partition when partition name exceed (backport #51503) #51536

merged 1 commit into from
Sep 30, 2024
+60 −3

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Sep 29, 2024 •
edited by wanpengfei-git
Loading

Why I'm doing:

When the list partition name exceeds the limit, timestamp will be used as a suffix, which may cause duplicate partitions to be created with the same partition value.

create table t(k string, v int)partition by (k) distributed by hash(v) buckets 1000;
-- result:
-- !result
insert into t values('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa', 1),('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa', 2);
-- result:
-- !result
show partitions from t;
-- result:
562021  paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa_1727581928327        2       2024-09-29 11:52:09     0       NORMAL  k       (('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'))     v       1000    3       HDD     9999-12-31 23:59:59     None    0B      false   0       2       314038295384293376      TXN_NORMAL
-- !result
create table t1 like t;
-- result:
-- !result
insert into t1 select * from t;
-- result:
-- !result
show partitions from t1;
-- result:
570028  paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa_1727581930411        2       2024-09-29 11:52:11     0       NORMAL  k       (('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'))     v       1000    3       HDD     9999-12-31 23:59:59     None    0B      false   0       2       314038299731689472      TXN_NORMAL
574029  paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa_1727581930422        2       2024-09-29 11:52:11     0       NORMAL  k       (('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'))     v       1000    3       HDD     9999-12-31 23:59:59     None    0B      false   0       2       314038299849129984      TXN_NORMAL
-- !result

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5
This is an automatic backport of pull request #51503 done by [Mergify](https://mergify.com). ## Why I'm doing: When the list partition name exceeds the limit, timestamp will be used as a suffix, which may cause duplicate partitions to be created with the same partition value. 
create table t(k string, v int)partition by (k) distributed by hash(v) buckets 1000;
-- result:
-- !result
insert into t values('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa', 1),('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa', 2);
-- result:
-- !result
show partitions from t;
-- result:
562021  paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa_1727581928327        2       2024-09-29 11:52:09     0       NORMAL  k       (('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'))     v       1000    3       HDD     9999-12-31 23:59:59     None    0B      false   0       2       314038295384293376      TXN_NORMAL
-- !result
create table t1 like t;
-- result:
-- !result
insert into t1 select * from t;
-- result:
-- !result
show partitions from t1;
-- result:
570028  paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa_1727581930411        2       2024-09-29 11:52:11     0       NORMAL  k       (('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'))     v       1000    3       HDD     9999-12-31 23:59:59     None    0B      false   0       2       314038299731689472      TXN_NORMAL
574029  paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa_1727581930422        2       2024-09-29 11:52:11     0       NORMAL  k       (('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'))     v       1000    3       HDD     9999-12-31 23:59:59     None    0B      false   0       2       314038299849129984      TXN_NORMAL
-- !result

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@meegoo @mergify
[BugFix] Fix duplicate list partition when partition name exceed (#51503
e4237c8 
)

Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit dcd238e)
@mergify mergify bot mentioned this pull request Sep 29, 2024
Merged
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 29, 2024 07:06
@sonarcloud SonarCloud
Copy link
sonarcloud bot commented Sep 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wanpengfei-git wanpengfei-git merged commit 5cc28ec into branch-3.2 Sep 30, 2024
35 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-51503 branch September 30, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meegoo meegoo meegoo approved these changes

Assignees

@meegoo meegoo

Labels
automerge version:3.2.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meegoo @wanpengfei-git