[Enhancement]implement dayofweek in FE #51453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: evenhuang <986025158@qq.com>
| // function of dayofweek in starrocks monday is 2 and sunday is 1, so need mod 7 and plus 1. | ||
| return ConstantOperator.createInt((date.getDatetime().getDayOfWeek().getValue()) % 7 + 1); | ||
| } | ||
|
|
||
| @ConstantFunction.List(list = { | ||
| @ConstantFunction(name = "years_add", argTypes = {DATETIME, | ||
| INT}, returnType = DATETIME, isMonotonic = true), |
There was a problem hiding this comment.
The most risky bug in this code is:
Using date.getDatetime().getDayOfWeek() on an integer type could cause a runtime exception.
You can modify the code like this:
@ConstantFunction.List(list = {
@ConstantFunction(name = "dayofweek", argTypes = {DATETIME}, returnType = INT),
@ConstantFunction(name = "dayofweek", argTypes = {DATE}, returnType = INT)
})
public static ConstantOperator dayofweek(ConstantOperator date) {
// LocalDateTime.getDayOfWeek is return day of the week, such as monday is 1 and sunday is 7.
// function of dayofweek in starrocks monday is 2 and sunday is 1, so need mod 7 and plus 1.
return ConstantOperator.createInt((date.getDatetime().getDayOfWeek().getValue()) % 7 + 1);
}
// Remove this entry as it handles integers which are not suitable for getDayOfWeek
@Deprecated
@ConstantFunction(name = "dayofweek", argTypes = {INT}, returnType = INT)
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
If the where condition contains a partition condition that is compared with the dayofweek function, a full table scan will be required, and FE is required to implement the dayofweek function to perform partition pruning when generating the execution plan.
What I'm doing:
implement dayofweek in FE
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
FE支持DAYOFWEEK 函数
实现前:
实现后:
Bugfix cherry-pick branch check: