Android notification system #1380
Conversation
| } | ||
| } | ||
| }); | ||
| }, []); |
There was a problem hiding this comment.
Necessary to catch navigation requests form the system
| } | ||
| systemClient.setCookie('federation', JSON.stringify(federationUrls)); |
There was a problem hiding this comment.
Informs the system about current coordinators and their URLs, useful when changing to tesnet and to avoid duplication on the systems' code
| @@ -3,6 +3,9 @@ | |||
|
|
|||
| <uses-permission android:name="android.permission.INTERNET" /> | |||
|
|
|||
| <uses-permission android:name="android.permission.POST_NOTIFICATIONS" /> | |||
| <uses-permission android:name="android.permission.FOREGROUND_SERVICE" /> | |||
There was a problem hiding this comment.
New permissions to run notifications
| fun updateTorKmpObject(newKmpObject: TorKmp) { | ||
| torKmp = newKmpObject | ||
| } | ||
| } |
There was a problem hiding this comment.
You can´t have 2 TorKmp running on your app, so this singleton makes sure it's accessible from the app and the notification foreground service
| @@ -1,132 +0,0 @@ | |||
| buildscript { | |||
bff1c74
to
b986c6e
Compare
b986c6e
to
444ca99
Compare
There was a problem hiding this comment.
Looks like we might have commited a few files under api/lightning that are not part of this PR and possibly shouod be ignored?
There was a problem hiding this comment.
I have no idea why but these files has been extremely persistent on being created, everytine I tried to do a commit they appear probably because after-commit, any clue?
|
Tested and merging after some users giving good feedback |
What does this PR do?
This PR includes all the necessary code to have torified notifications. A background job runs every 5 minutes, even if the app is off, to check if the user has new notifications on their active orders. Important points to consider:
This code also takes into consideration #1356, being compatible with latest release's code and these changes.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.