[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leftover bits from the campaign export removal #4616

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Remove leftover bits from the campaign export removal #4616

merged 3 commits into from
Jan 6, 2024

Conversation

kwvanderlinde
Copy link
Collaborator
@kwvanderlinde kwvanderlinde commented Jan 3, 2024 •
edited by cwisniew
Loading

Identify the Bug or Feature request

Improves #4047

Description of the Change

PR #4065 removed the code for campaign exports, but the translation strings and a form file were left behind. This PR fixes that up.

One string msg.confirm.campaignExported was mistakenly still in use as the confirmation for exporting campaign repository files. This has been replaced with msg.confirm.campaignRepoExported with a more accurate message.

Possible Drawbacks

None

Documentation Notes

N/A

Release Notes

  • Fixed confirmation message shown when exporting a campaign repository.

This change is Reviewable

@kwvanderlinde
Fix i18n string for campaign repository export
6f92e59 
Instead of saying "Campign exported", the confirmation now reads "Campaign repository exported" with a matching new key.
@kwvanderlinde
Remove i18n strings for removed campaign exports
64b1d64
@kwvanderlinde
Remove unused campaignExportDialog.xml
8870199
bubblobill
bubblobill approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator
@bubblobill bubblobill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You caught all the strings I could find.

@cwisniew cwisniew added this pull request to the merge queue Jan 6, 2024
@cwisniew cwisniew added the refactor Refactoring the code for optimal awesomeness. label Jan 6, 2024
Merged via the queue into RPTools:develop with commit f9cdd10 Jan 6, 2024
4 checks passed
bubblobill added a commit to bubblobill/maptool that referenced this pull request Jan 7, 2024
@bubblobill
Resolved conflicts arising from RPTools#4616
9ea1aa5
@kwvanderlinde kwvanderlinde deleted the refactor/4047-i18n-strings branch January 9, 2024 09:11
@cwisniew cwisniew added the code-maintenance Adding/editing javadocs, unit tests, formatting. label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bubblobill bubblobill bubblobill approved these changes

@cwisniew cwisniew cwisniew approved these changes

Assignees
No one assigned
Labels
code-maintenance Adding/editing javadocs, unit tests, formatting. refactor Refactoring the code for optimal awesomeness.
Projects
MapTool Release 1.15.0
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwvanderlinde @cwisniew @bubblobill