fix: Sakuranovel #560
Merged
fix: Sakuranovel #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,12 +91,12 @@ class WPMangaStreamScraper { | |||
| novel.genre = loadedCheerio('.genxed').text().trim().replace(/\s/g, ','); | |||
|
|
|||
| novel.summary = loadedCheerio('.entry-content') | |||
| .find('h3') | |||
| .find('h3 , p.a') | |||
There was a problem hiding this comment.
I checked on the source sites, wouldn't div[itemprop="description"] be a better selector?
novel.summary = loadedCheerio('div[itemprop="description"]').text()
There was a problem hiding this comment.
I basically want to make the summary look cleaner by removing those within the box
so with this
novel.summary = loadedCheerio('div[itemprop="description"]').text()
it looks like this
so I try to rectify it (somewhat, I wish I could do better) with this,
novel.summary = loadedCheerio('.entry-content') .find('h3 , p.a') .remove() .end() .prop('innerHTML') .replace(/(<.*?>)/g, ' ') .replace(/(&.*;)/g, '\n');
so it looks something like this,
rajarsheechatterjee
approved these changes
Feb 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes LNReader/lnreader-plugins#456 (comment)
images don't appear consistently, but I think that's more on the source's side.