fix(delete_chapter): Excessive number of pending callbacks warn #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes there would be "Excessive number of pending callbacks" warn shown. Removing chapters in batches of 10 (I tried 30 but it was still an issue) seems to work fine now. TODO: Add some icon about deletion status and make it not lag the entire app.
Make deleting chapters do 3 coccurent deletion at a time making it work similarly to bluebird's `Promise.map(,{coccurent:3})` and removing the `Excessive number of pending callbacks` warn gone.
rajarsheechatterjee
approved these changes
Nov 26, 2022
|
Oh yeah. I forgot something like that was an option. I learned fuck ton of SQL in school. I'm going to try and do that tomorrow and see if it works |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make deleting chapters do 5 coccurent deletion at a time, thus removing the
Excessive number of pending callbackswarn.