improvements #1564
Merged
improvements #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d data is attached. These graphs have the advantage of being able to be re-usable, as generally all information about commits is kept.
3 tasks
A way to insert a full commit with a single update functions that has access to the full commit, not just the data.
…sert_default()` and `Graph::try_lookup_or_insert_commit()` to `*::get_or_insert_commit()`
…rge-base`. This would be a breaking change, but the previous addition of `merge-base` wasn't released yet.
That way, multiple calls to merge-base can be more optimal. Note that this is a breaking change, but there wasn't a release yet so there is no need to mark it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make merge_base more efficient by using
Commits that can be re-used across calls.Tasks
is_newis actually needed - it's probably not needed after all