[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update datasets #114

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Update datasets #114

wants to merge 13 commits into from

Conversation

ahasverus
Copy link
Member

This PR is dedicated to remove previous example datasets (IUCN & Pantheria) and replace it by the WOODIV database.

Changes

  • export new formatted data in data/
  • edit dataset documentation in R/datasets.R
  • export raw data in inst/extdata/
  • rename the raw data in funbiogeo_raw_data.csv
  • update examples inf fb_format_*() functions
  • update vignettes/ and tests/

In addition, list fundiversity package in Suggests.

@ahasverus ahasverus requested a review from Rekyt April 15, 2024 07:38
@ahasverus ahasverus added the documentation Improvements or additions to documentation label Apr 15, 2024
@ahasverus
Copy link
Member Author

Note: there is no missing values in this dataset.

Rekyt
Rekyt requested changes Jul 25, 2024
View reviewed changes
R/datasets.R Outdated Show resolved Hide resolved
R/datasets.R Outdated Show resolved Hide resolved
R/datasets.R Outdated Show resolved Hide resolved
R/datasets.R Outdated Show resolved Hide resolved
R/datasets.R Outdated Show resolved Hide resolved
tests/testthat/test-fb_plot_site_traits_completeness.R Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

vignettes/diagnostic-plots.Rmd Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll take care of updating the vignette instead of striking through all of the wrong interpretations of the graph.

vignettes/funbiogeo.Rmd
[@Jones_PanTHERIA_2009].
The initial extraction scripts are available
on [GitHub](https://github.com/FRBCesab/eumammals).
We are interested in mapping the functional traits of 26 Rosacean tree species of Western European Mediterranean regions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could copy the statement from man page to explain where the data are coming from.

vignettes/funbiogeo.Rmd
@@ -238,8 +229,8 @@ head(red_sp_traits)
```

The function outputs a filtered species-traits dataset retaining only traits
covering at least 75% of the species. In the end this keep two traits: body mass
and litter size.
covering at least 75% of the species. ~~In the end this keep two traits: body mass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be updated

vignettes/funbiogeo.Rmd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as for the diagnostic plots, need to check interpretation of each graph

@Rekyt
Copy link
Collaborator
Rekyt commented Jul 25, 2024

Great work on this PR.
One thing I wonder is that we could use this opportunity to rename the example dataset to something slightly different from the default arguments' names.
Because I think this is quite confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekyt Rekyt Rekyt requested changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahasverus @Rekyt