[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top margin in Firefox when Sweet window borders are selected #115

Closed
AndreiMiculita opened this issue Oct 12, 2020 · 2 comments
Closed

Top margin in Firefox when Sweet window borders are selected #115

AndreiMiculita opened this issue Oct 12, 2020 · 2 comments

Comments

@AndreiMiculita
Copy link
AndreiMiculita commented Oct 12, 2020 •
edited
Loading

Hi, Firefox has a top margin when the Sweet window borders are selected. This bothers me because it makes it a lot more difficult to select tabs since they're not at the edge of the screen. It's a mistake I've seen other theme devs make as well. Could you please look into it? Thank you :)

I'm using the Cinnamon DE.
@AndreiMiculita
Copy link
Author
AndreiMiculita commented Dec 15, 2020 •
edited
Loading

Found the fix.
Here, on line 108:

Sweet/metacity-1/metacity-theme-3.xml

Lines 103 to 111 in 4e9666c

<!-- Borderless -->
<frame_geometry name="borderless" has_title="false" rounded_top_left="false" rounded_top_right="false" parent="normal">
<distance name="left_width" value="0" />
<distance name="right_width" value="0" />
<distance name="bottom_height" value="0" />
<distance name="title_vertical_pad" value="8" />
<border name="title_border" left="0" right="0" top="0" bottom="0" />
<border name="button_border" left="0" right="0" top="0" bottom="0" />
</frame_geometry>

The padding should be set to 0, like this:

<distance name="title_vertical_pad" value="0" />

EliverLara added a commit that referenced this issue Dec 17, 2020
@EliverLara
Cinnamon: Fix top border appearing when window is maximized #115
ea38f15
EliverLara added a commit that referenced this issue Dec 17, 2020
@EliverLara
Cinnamon: Fix top border appearing when window is maximized #115
6a88645
EliverLara added a commit that referenced this issue Dec 17, 2020
@EliverLara
Cinnamon: Fix top border appearing when window is maximized #115
69a615e
EliverLara added a commit that referenced this issue Dec 17, 2020
@EliverLara
Cinnamon: Fix top border appearing when window is maximized #115
c3e01ac
EliverLara added a commit that referenced this issue Dec 17, 2020
@EliverLara
Cinnamon: Fix top border appearing when window is maximized #115
06a6e58
@EliverLara
Copy link
Owner

@AndreiMiculita Thank you for providing the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreiMiculita @EliverLara